Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null-handling in Wrap-Method in factories for IDriveInfo or IFileSystemWatcher #977

Merged

Conversation

vbreuss
Copy link
Member

@vbreuss vbreuss commented Apr 24, 2023

Building on #976 also fix null-handling for DriveInfo and FileSystemWatcher factories:
When providing null as parameter to the implementations of IDriveInfoFactory or IFileSystemWatcherFactory return null instead of throwing an exception.

This extends the issue reported in #975 to other factories used in System.IO.Abstractions.

@mergify mergify bot merged commit 554e97c into TestableIO:main Apr 24, 2023
10 checks passed
@vbreuss vbreuss deleted the topic/vb/fix-nullable-in-factories2 branch April 24, 2023 06:43
vbreuss pushed a commit to Testably/Testably.Abstractions that referenced this pull request Apr 25, 2023
…19.2.18 (#301)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions)
| nuget | patch | `19.2.16` -> `19.2.18` |

---

### Release Notes

<details>
<summary>TestableIO/System.IO.Abstractions</summary>

###
[`v19.2.18`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.18)

#### What's Changed

- fix: null-handling in Wrap-Method in factories for `IDriveInfo` or
`IFileSystemWatcher` by [@&#8203;vbreuss](https://togithub.com/vbreuss)
in
[TestableIO/System.IO.Abstractions#977

**Full Changelog**:
TestableIO/System.IO.Abstractions@v19.2.17...v19.2.18

###
[`v19.2.17`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.17)

##### What's Changed

- fix: null-handling in Wrap-Method in factories for `IDirectoryInfo` or
`IFileInfo` by [@&#8203;vbreuss](https://togithub.com/vbreuss) in
[TestableIO/System.IO.Abstractions#976

**Full Changelog**:
TestableIO/System.IO.Abstractions@v19.2.16...v19.2.17

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/Testably/Testably.Abstractions).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS41Ny4wIiwidXBkYXRlZEluVmVyIjoiMzUuNTguMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented May 4, 2023

This is addressed in release v19.2.18.

@github-actions github-actions bot added the state: released Issues that are released label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: released Issues that are released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants