Merge pull request #577 from nilennoct/fix/trigger_select_click_events

fix: trigger click event on `<select>` elements correctly
Tencent · Nov 2, 2022 · 95864fa · 95864fa
2 parents ecc524b + fc8a4a9
commit 95864fa
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/core/core.svelte b/src/core/core.svelte
@@ -251,7 +251,7 @@
     touchMove(e) {
       const touch = e.changedTouches[0];
       if (
-        Math.abs(touch.pageX - mockTapInfo.touchstartX) > mockTapInfo.tapBoundary || 
+        Math.abs(touch.pageX - mockTapInfo.touchstartX) > mockTapInfo.tapBoundary ||
         Math.abs(touch.pageY - mockTapInfo.touchstartY) > mockTapInfo.tapBoundary
       ) {
         mockTapInfo.touchHasMoved = true;
@@ -261,15 +261,18 @@
     touchEnd(e) {
       // move and time within limits, manually trigger `click` event
       if (
-        mockTapInfo.touchHasMoved === false && 
-        e.timeStamp - mockTapInfo.lastTouchStartTime < mockTapInfo.tapTime && 
+        mockTapInfo.touchHasMoved === false &&
+        e.timeStamp - mockTapInfo.lastTouchStartTime < mockTapInfo.tapTime &&
         mockTapInfo.targetElem != null
       ) {
         const tagName = mockTapInfo.targetElem.tagName.toLowerCase();
         let needFocus = false;
         switch (tagName) {
           case 'textarea': // focus
             needFocus = true; break;
+          case 'select':
+            needFocus = !mockTapInfo.targetElem.disabled && !mockTapInfo.targetElem.readOnly;
+            break;
           case 'input':
             switch (mockTapInfo.targetElem.type) {
               case 'button':