fix(pagination): fix pageSize param when page change #4450
Merged
+5
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1379255913
requested review from
PengYYYYY,
chaishi,
xiaosansiji,
honkinglin,
LeeJim and
uyarn
as code owners
|
|
uyarn
changed the title
uyarn
approved these changes
Aug 5, 2024
Merged
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
表格改变每页行数时，@page-change事件参数不正确是因为在pageSize发生改变且会改变目前current值时，触发的handlePageChange会先执行setInnerPageSize，如果没有对onPageSize进行处理，会无法更新pageSize的值，而后触发的toPage函数获取pageInfo时，会尝试从props中进行获取，这就会导致获取不到最新的pageSize，从而引发bug
这里发现原来的isTriggerChange仅在上述情况下会使用，所以将其改为了pageInfo用于直接传入数据，避免了从props中无法出现最新值的问题
📝 更新日志
fix(Pagination): 修复
pagination在pageSize改变时onChange无法获取最新pageSize的问题本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单