Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong span #425

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Fix wrong span #425

merged 1 commit into from
Aug 25, 2020

Conversation

CreepySkeleton
Copy link
Collaborator

Closes #424

@d-e-s-o
Copy link

d-e-s-o commented Aug 25, 2020

Once that change is in, would it be possible to cut a new release? I need the fix for work I am currently doing.

@TeXitoi
Copy link
Owner

TeXitoi commented Aug 25, 2020

@d-e-s-o won't it only affect error messages?

@TeXitoi
Copy link
Owner

TeXitoi commented Aug 25, 2020

self reply: OK read the corresponding issue, it's not.

@CreepySkeleton CreepySkeleton merged commit f7fcda2 into master Aug 25, 2020
@CreepySkeleton CreepySkeleton deleted the span branch August 25, 2020 17:26
@CreepySkeleton
Copy link
Collaborator Author

@d-e-s-o 0.3.17 Behold: is about to be released!

@d-e-s-o
Copy link

d-e-s-o commented Aug 26, 2020

Thank you @CreepySkeleton & @TeXitoi for the fast turnaround on this one! Greatly appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeXitoi TeXitoi TeXitoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error[E0425]: cannot find value app in this scope
3 participants
@CreepySkeleton @d-e-s-o @TeXitoi