Added headers to config for fixing ase.in.tum #1348
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Testserver will be ready at https://1348.test.live.mm.rbg.tum.de in a few minutes. Logins
|
|
Which headers do they need? |
|
Access-Control-Allow-Origin with value ase.in.tum.de, because they told us else they can't edit the jframes on their website with javascript |
There was a problem hiding this comment.
This could also be handled using traefik https://doc.traefik.io/traefik/middlewares/http/headers/
|
Ok so we shouldn't do it with gin directly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixed ticket of ase in tum
Description
Added headers to config