Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

player control: 'next' button #1268

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

PSandro
Copy link

@PSandro PSandro commented Dec 18, 2023

Motivation and Context

This change aims to provide a quick way of navigating to the next video in queue. Currently this is possible via the playlist functionality. But opening the playlist view and clicking on the 'next' button there requires some mouse pointer movement an more than 1 click :)

The alternative would be to have a 'skip'/'next' button right next to the pause/play button in the player control bar of the videoplayer. This PR tries to implement exactly that.

fixes #1170

Description

Changes made only affect the web part of gocast. The DataStore and StreamPlaylistEntry is added to the Video.js setup code in TUMLiveVjs.ts. The streamID of the current stream is used to - if exists - fetch the stream's playlist and get the next video in line which then gets linked to via the 'next' button.

Steps for Testing

As I could not test the changes locally myself, testing would rely on the test deployment through CI. One would need to open a stream and confirm that the 'next' button is indeed shown and links to the next video in the playlist. Therefor one could use the existing playlist navigation in the playlist view, then go back and try the same thing using the newly added 'next' button in the player control bar.

Screenshots

Since I could not test the setup locally, there are no screenshots yet. I will updated them as soon as possible.

This is a draft for now since probably more development is needed.

@PSandro
Copy link
Author

PSandro commented Dec 21, 2023

@alexanderstephan could you please approve the ci workflows? Thanks :)

@alexanderstephan alexanderstephan marked this pull request as ready for review December 21, 2023 15:31
@alexanderstephan
Copy link
Collaborator

@PSandro done :) If you plan to do more work on TUM-Live, we can add you as a project member. Make sure to merge the latest master to get the updated linter settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Next"/"Skip" video control button
2 participants