Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow older windows-sys 0.52 #304

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

king-11
Copy link
Contributor

@king-11 king-11 commented Nov 4, 2024

dependabot bumped the version to 0.59 but older version 0.52 can also be supported allowing downstream crates to pull dependency as per their version choice.

dependabot bumped the version to 0.59 but older version 0.52 can also be supported allowing upstream crates to pull dependency as per their version choice.
@Stebalien
Copy link
Owner

Why?

@king-11
Copy link
Contributor Author

king-11 commented Nov 5, 2024

I don't think tempfile makes use of any API change which might have been introduced with 0.59 so keeping the range would prevent dependency hell for other downstream dependencies to only pull one version and I have mostly found that to be version 0.52.

@Stebalien
Copy link
Owner

Hm. There's no guarantee that'll work as you expect (rust-lang/cargo#10599) but it's unlikely to hurt given that this dependency isn't exported.

@Stebalien Stebalien merged commit fa8ad00 into Stebalien:master Nov 5, 2024
13 checks passed
@king-11 king-11 deleted the patch-1 branch November 5, 2024 04:29
@king-11
Copy link
Contributor Author

king-11 commented Nov 5, 2024

Yep the resolver can't really make out of this NP hard problem but many a times it works and gets the right one.

@Stebalien
Copy link
Owner

3.14 published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants