Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integer overflows and truncation #278

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Fix integer overflows and truncation #278

merged 2 commits into from
Feb 26, 2024

Commits on Feb 26, 2024

  1. fix: handle size truncation on 32 bit systems 

    If tempfile is used on a 32 bit system, usize is u32. This means that
casting u64 to usize may truncate the value.

Test added to clarify the issue.
    @stoeckmann
    stoeckmann committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    61a813b View commit details
    Browse the repository at this point in the history

  2. fix: handle integer overflows 

    Passing huge values might lead to integer overflows during calculations.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
    @stoeckmann
    stoeckmann committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    aa06096 View commit details
    Browse the repository at this point in the history