Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLCORE-760 Define explicit JVM heap size on SLOOP start #916

Closed
wants to merge 3 commits into from

Conversation

kirill-knize-sonarsource
Copy link
Contributor

No description provided.

Copy link
Contributor

@damien-urruty-sonarsource damien-urruty-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am concerned that setting the value to 2G might in fact lower the max heap size on some environments where the default is higher. On my Linux, if I run the following:

java -client -XX:+PrintFlagsFinal 2>&1 | grep -i -E 'MaxHeapSize'

I get:

size_t MaxHeapSize = 8340373504 {product} {ergonomic}

Which is close to 8G if I'm not wrong. So with the Xmx option set to 2028M, we would be in fact lowering the max heap size on some machines.

My second concern is, if I understand correctly, starting the JVM will fail if the OS is not able to allocate the amount of memory requested.

I'm not an expert with those settings, so I can't say with confidence if we should move forward with this change

@damien-urruty-sonarsource
Copy link
Contributor

Closing as per the concern shared above about having a hardcoded size lower than the default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants