Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCANNPM-2 polish logging and cleanup invalid cache #141

Conversation

lucas-paulger-sonarsource

No description provided.

src/file.ts Fixed Show fixed Hide fixed
@lucas-paulger-sonarsource lucas-paulger-sonarsource force-pushed the task/lp/cleanup-logger-and-cleanup-invalid-cache branch from 465a473 to 4915160 Compare May 9, 2024 09:44
@lucas-paulger-sonarsource lucas-paulger-sonarsource force-pushed the task/lp/cleanup-logger-and-cleanup-invalid-cache branch from 4915160 to cd8bedb Compare May 9, 2024 11:04
@lucas-paulger-sonarsource lucas-paulger-sonarsource force-pushed the task/lp/cleanup-logger-and-cleanup-invalid-cache branch 5 times, most recently from a4ccd1a to 21da515 Compare May 13, 2024 12:43
Copy link

@vdiez vdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some changes related to the fact that canonicalBasePath is not used any more

src/file.ts Outdated Show resolved Hide resolved
src/java.ts Outdated Show resolved Hide resolved
src/scanner-cli.ts Outdated Show resolved Hide resolved
src/scanner-cli.ts Outdated Show resolved Hide resolved
test/unit/file.test.ts Outdated Show resolved Hide resolved
test/unit/file.test.ts Outdated Show resolved Hide resolved
test/unit/scanner-cli.test.ts Outdated Show resolved Hide resolved
test/unit/scanner-cli.test.ts Outdated Show resolved Hide resolved
src/file.ts Outdated Show resolved Hide resolved
@lucas-paulger-sonarsource lucas-paulger-sonarsource force-pushed the task/lp/cleanup-logger-and-cleanup-invalid-cache branch from 21da515 to 7288fd2 Compare May 13, 2024 13:26
Copy link

@vdiez vdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment, to mutualize usage of fs-extra everywhere. otherwise, LGTM!!

test/unit/scanner-engine.test.ts Outdated Show resolved Hide resolved
@lucas-paulger-sonarsource lucas-paulger-sonarsource force-pushed the task/lp/cleanup-logger-and-cleanup-invalid-cache branch from 0b784a2 to c7fc404 Compare May 13, 2024 14:34
src/file.ts Dismissed Show dismissed Hide dismissed
@lucas-paulger-sonarsource lucas-paulger-sonarsource force-pushed the task/lp/cleanup-logger-and-cleanup-invalid-cache branch from c7fc404 to 2caa5b6 Compare May 13, 2024 14:45
Copy link

sonarcloud bot commented May 13, 2024

@lucas-paulger-sonarsource lucas-paulger-sonarsource merged commit b3396c3 into feature/MMF-3712 May 13, 2024
7 checks passed
@lucas-paulger-sonarsource lucas-paulger-sonarsource deleted the task/lp/cleanup-logger-and-cleanup-invalid-cache branch May 13, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants