SONARPY-1783 Migrate ArgumentNumberCheck to the new type model #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksim-grebeniuk-sonarsource
requested a review
from guillaume-dequenne-sonarsource
maksim-grebeniuk-sonarsource
force-pushed
the
mg/SONARPY-1783-rule
branch
8 times, most recently
from
dc3cd67
to
97bc152
Compare
maksim-grebeniuk-sonarsource
force-pushed
the
mg/SONARPY-1783-rule
branch
from
97bc152
to
ba7c745
Compare
|
There was a problem hiding this comment.
To be honest, I didn't do a thorough review of this PR yet.
However given the many FPs this introduces and the shift in our approach, I suggest we don't touch this PR for now and we come back to it when we feel ready to deliver the updated NonCallableCalledCheck to production. Then we can use this rule to track which feature we're still missing so that we can prioritize them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.