SONARPY-1829 tmp commit

SonarSource · May 8, 2024 · 4a5bb73 · 4a5bb73
1 parent a14f095
commit 4a5bb73
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 4 deletions.
diff --git a/python-checks/src/test/resources/checks/nonCallableCalled.py b/python-checks/src/test/resources/checks/nonCallableCalled.py
@@ -228,3 +228,13 @@ def my_callable(): ...
         def my_callable(): ...
         my_callable = 42
         my_callable()  # Noncompliant
+
+
+def reassigned_class():
+    if cond:
+        class MyClass(): ...
+        MyClass()  # OK
+    else:
+        def MyClass(): ...
+        MyClass = 42
+        MyClass()  # Noncompliant
diff --git a/...rontend/src/main/java/org/sonar/python/semantic/v2/types/TrivialTypeInferenceVisitor.java b/...rontend/src/main/java/org/sonar/python/semantic/v2/types/TrivialTypeInferenceVisitor.java
@@ -357,14 +357,14 @@ public void visitName(Name name) {
       }
     }
 
-    bindingUsages.stream()
+/*    bindingUsages.stream()
       .findFirst()
       .filter(UsageV2::isBindingUsage)
       .map(UsageV2::tree)
       .filter(Expression.class::isInstance)
       .map(Expression.class::cast)
       .map(Expression::typeV2)
-      .ifPresent(type -> setTypeToName(name, type));
+      .ifPresent(type -> setTypeToName(name, type));*/
   }
 
   private PythonType currentType() {

diff --git a/python-frontend/src/main/java/org/sonar/python/types/v2/ClassType.java b/python-frontend/src/main/java/org/sonar/python/types/v2/ClassType.java
@@ -182,7 +182,7 @@ public boolean equals(Object o) {
 
   @Override
   public int hashCode() {
-    return Objects.hash(name, members, attributes, superClasses);
+    return Objects.hash(name, members, attributes);
   }
 
   @Override

diff --git a/python-frontend/src/test/java/org/sonar/python/semantic/v2/TypeInferenceV2Test.java b/python-frontend/src/test/java/org/sonar/python/semantic/v2/TypeInferenceV2Test.java
@@ -245,7 +245,6 @@ def foo(a, b): ...
   }
 
   @Test
-  @Disabled("ClassDef not in CFG prevents us from getting this to work")
   void multipleClassDefinitions() {
     FileInput root = inferTypes("""
       class MyClass(int): ...