Fix NPE on S5642 (#1678)

SonarSource · Dec 5, 2023 · 247d534 · 247d534
1 parent a18bd20
commit 247d534
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/python-checks/src/main/java/org/sonar/python/checks/UseOfAnyAsTypeHintCheck.java b/python-checks/src/main/java/org/sonar/python/checks/UseOfAnyAsTypeHintCheck.java
@@ -19,6 +19,7 @@
  */
 package org.sonar.python.checks;
 
+import java.util.Objects;
 import java.util.Optional;
 import java.util.Set;
 import java.util.function.Predicate;
@@ -72,6 +73,7 @@ private static boolean hasFunctionOverrideOrOverloadDecorator(FunctionDef curren
     return currentFunctionDef.decorators().stream()
       .map(Decorator::expression)
       .map(TreeUtils::fullyQualifiedNameFromExpression)
+      .filter(Objects::nonNull)
       .anyMatch(OVERRIDE_FQNS::contains);
   }
 

diff --git a/python-checks/src/test/resources/checks/useOfAnyAsTypeHint.py b/python-checks/src/test/resources/checks/useOfAnyAsTypeHint.py
@@ -114,3 +114,7 @@ def other_function(self, other: Any, text: str) -> None: # Compliant
 
     def return_type_check(self, text) -> Any: # Compliant
         ...
+
+    @my_annotation[42]
+    def some_annotated_method(self, text: Any):  # Noncompliant
+        ...