S1066: Add reproducer for #9221 #9264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastien-marichal
requested changes
May 13, 2024
Comment on lines
75
to
81
| dynamic anything = "2024-04-29"; | ||
|
|
||
| if (anything is string) // Secondary | ||
| if (DateTime.TryParseExact(anything, "yyyy-MM-dd", CultureInfo.InvariantCulture, DateTimeStyles.None, out DateTime dt)) // Noncompliant FP | ||
| return dt; | ||
|
|
||
| return null; |
There was a problem hiding this comment.
I would add more test cases based on what @pavel-mikula-sonarsource said about not raising if there is a dynamic in the statement:
if (notDynamic is not null)
if (notDynamic == "something" && anything is string) // Noncompliant (not sure if FP or not there)
return null;
if (notDynamic is not null)
if (notDynamic == "something") // Noncompliant (to make sure we do not deactivate S1066 for the whole block)
return null;
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducer for #9221