Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change VerifyNoIssuesReported to not ignore errors #9259

Merged
merged 1 commit into from
May 8, 2024

Conversation

Tim-Pohlmann
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann commented May 8, 2024

Part of #9237

  • renames VerifyNoIssuesReported -> VerifyNoIssuesIgnoreErrors
  • add new method VerifyNoIssues that does not ignore errors

Copy link
Contributor

@CristianAmbrosini CristianAmbrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! well done

@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban May 8, 2024
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 8, 2024

@Tim-Pohlmann Tim-Pohlmann merged commit 1e73b8c into master May 8, 2024
26 checks passed
Best Kanban automation moved this from Review approved to Validate Peach May 8, 2024
@Tim-Pohlmann Tim-Pohlmann deleted the Tim/VerifyNoIssues branch May 8, 2024 12:37
@Tim-Pohlmann Tim-Pohlmann moved this from Validate Peach to Done in Best Kanban May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Best Kanban
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants