Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix T0010 FP: Allow delegate type parameter name #9258

Merged
merged 5 commits into from May 8, 2024

Conversation

martin-strecker-sonarsource
Copy link
Contributor

Fixes

public delegate void SomeDelegate(int someParameterName);

public void Use(SomeDelegate action) { }

public void Test()
{
    Use(x => { }); // Compliant
    Use(someParameterName => { }); // FP
}

@github-actions github-actions bot added this to In progress in Best Kanban May 6, 2024
@martin-strecker-sonarsource martin-strecker-sonarsource marked this pull request as ready for review May 7, 2024 13:32
@pavel-mikula-sonarsource pavel-mikula-sonarsource changed the title Fix TP0010 FP: Allow delegate type parameter name Fix P0010 FP: Allow delegate type parameter name May 7, 2024
@pavel-mikula-sonarsource pavel-mikula-sonarsource changed the title Fix P0010 FP: Allow delegate type parameter name Fix T0010 FP: Allow delegate type parameter name May 7, 2024
@sebastien-marichal sebastien-marichal self-requested a review May 8, 2024 11:06
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban May 8, 2024
Copy link
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one concern, and I would like to get your opinion.

@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban May 8, 2024
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 8, 2024

@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban May 8, 2024
Copy link
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sebastien-marichal sebastien-marichal merged commit 8b6f0f5 into master May 8, 2024
31 checks passed
@sebastien-marichal sebastien-marichal deleted the Martin/FP_T0010_DelegateParameterName branch May 8, 2024 14:56
Best Kanban automation moved this from Review in progress to Validate Peach May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Best Kanban
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants