Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve S6967: Filter out CancellationToken parameters #9236

Merged
merged 1 commit into from May 1, 2024
Merged

Improve S6967: Filter out CancellationToken parameters #9236

merged 1 commit into from May 1, 2024

Conversation

zsolt-kolbay-sonarsource
Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource commented May 1, 2024 •
edited

Improves #9095
Fixes FPs where the controller action only has a CancellationToken parameter:

[HttpGet]
public async Task<IActionResult> Index(CancellationToken token)
{
    return View();
}

@github-actions github-actions bot added this to In progress in Best Kanban May 1, 2024
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban May 1, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

gregory-paidis-sonarsource
gregory-paidis-sonarsource approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregory-paidis-sonarsource gregory-paidis-sonarsource merged commit 1e3dc1d into master May 1, 2024
29 checks passed
Best Kanban automation moved this from Review in progress to Validate Peach May 1, 2024
@gregory-paidis-sonarsource gregory-paidis-sonarsource deleted the Zsolt/S6967-CancellationToken-parameter branch May 1, 2024 15:32
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource moved this from Validate Peach to Done in Best Kanban May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregory-paidis-sonarsource gregory-paidis-sonarsource gregory-paidis-sonarsource approved these changes

Assignees

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource

Labels
None yet
Projects
Best Kanban
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zsolt-kolbay-sonarsource @gregory-paidis-sonarsource