Add UTs to test Razor Expressions locations #9224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Pohlmann
approved these changes
Apr 30, 2024
analyzers/tests/SonarAnalyzer.Test/Rules/Utilities/SymbolReferenceAnalyzerTest.cs
Outdated
Show resolved
Hide resolved
| @@ -227,7 +227,7 @@ public void Verify_UnchangedFiles(string unchangedFileName, bool expectedProtobu | |||
| orderedSymbols[0].FilePath.Should().EndWith("_Imports.razor"); | |||
| orderedSymbols[1].FilePath.Should().EndWith("Razor.razor"); | |||
|
|
|||
| VerifyReferences(orderedSymbols[1].Reference, 9, 13, 4, 6, 20); // currentCount | |||
| VerifyReferences(orderedSymbols[1].Reference, 9, 13, 4, 6, 20, 48); // currentCount | |||
There was a problem hiding this comment.
Fix the T0010 violation in line 223 by renaming symbol to x.
| @@ -352,6 +357,10 @@ private VerifierBuilder CreateBuilder(ProjectType projectType, params string[] f | |||
| .Should().BeEquivalentTo(assertedDeclarationLineReferences); | |||
| } | |||
|
|
|||
| private static void VerifyReferencesColumns(IReadOnlyList<SymbolReferenceInfo.Types.SymbolReference> symbolReference, int declarationLine, int startLine, int endLine, int startOffset, int endOffset) => | |||
There was a problem hiding this comment.
This violates S103 and should be
Suggested change
| private static void VerifyReferencesColumns(IReadOnlyList<SymbolReferenceInfo.Types.SymbolReference> symbolReference, int declarationLine, int startLine, int endLine, int startOffset, int endOffset) => | |
| private static void VerifyReferencesColumns(IReadOnlyList<SymbolReferenceInfo.Types.SymbolReference> symbolReference, | |
| int declarationLine, | |
| int startLine, | |
| int endLine, | |
| int startOffset, | |
| int endOffset) => |
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.