Repro for FP S2589: Assignment for captures are ignored #9205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Pohlmann
approved these changes
Apr 25, 2024
Comment on lines
4264
to
4275
| public bool LocalFunctionTest() | ||
| { | ||
| var found = false; | ||
| Assign(); | ||
| if (!found) // Noncompliant FP | ||
| { | ||
| Console.WriteLine("No License for artifact type"); | ||
| } | ||
| return found; | ||
|
|
||
| void Assign() => found = true; // Assignment in local function | ||
| } |
There was a problem hiding this comment.
I added a reproducer for #8885 as well.
github-actions
bot
assigned martin-strecker-sonarsource and unassigned martin-strecker-sonarsource
|
|
github-actions
bot
moved this from Review approved
to Review in progress
in Best Kanban
| @@ -57,7 +57,9 @@ public class ConditionEvaluatesToConstantTest | |||
| [DataRow(ProjectType.Test)] | |||
| public void ConditionEvaluatesToConstant_Roslyn_CS(ProjectType projectType) => | |||
| roslynCS.AddPaths("ConditionEvaluatesToConstant.cs") | |||
| .AddReferences(NuGetMetadataReference.MicrosoftExtensionsPrimitives("3.1.7").Concat(TestHelper.ProjectTypeReference(projectType))) | |||
| .AddReferences(NuGetMetadataReference.MicrosoftExtensionsPrimitives("3.1.7")) | |||
| .AddReferences(MetadataReferenceFacade.SystemComponentModelTypeConverter) | |||
There was a problem hiding this comment.
For System.Timers.Timer
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repro for #9204
Repro for #8885