Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate S6803 #9189

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Deprecate S6803 #9189

merged 3 commits into from
Apr 24, 2024

Conversation

mary-georgiou-sonarsource
Copy link
Contributor

S6803
rspec update: SonarSource/rspec#3910

After discussing the impact of this rule we decided to deprecate it.

The rule applies < .NET8
It has a very low impact
It applies only to sealed components

@github-actions github-actions bot added this to In progress in Best Kanban Apr 23, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource added this to the 9.25 milestone Apr 23, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource added Type: Improvement Making existing code better. Area: C# C# rules related issues. labels Apr 23, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title Deprecate s6803 Deprecate S6803 Apr 23, 2024
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Apr 24, 2024
@costin-zaharia-sonarsource costin-zaharia-sonarsource merged commit b8b6170 into master Apr 24, 2024
28 checks passed
Best Kanban automation moved this from Review approved to Validate Peach Apr 24, 2024
@costin-zaharia-sonarsource costin-zaharia-sonarsource deleted the mary/deprecate-S6803 branch April 24, 2024 10:00
@mary-georgiou-sonarsource mary-georgiou-sonarsource moved this from Validate Peach to Done in Best Kanban Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: C# C# rules related issues. Type: Improvement Making existing code better.
Projects
Best Kanban
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants