-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Rule T0016: Separate declarations by an empty line #9147
Conversation
analyzers/tests/SonarAnalyzer.CSharp.Styling.Test/TestCases/SeparateDeclarations.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must admit, it took me a while to review 😅
There is a missing test case.
There is one thing that I didn't quite understand, I left a comment.
analyzers/src/SonarAnalyzer.CSharp.Styling/Rules/SeparateDeclarations.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.CSharp.Styling.Test/TestCases/SeparateDeclarations.cs
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp.Styling/Rules/SeparateDeclarations.cs
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #9130