Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve discoverability of nuget packages #9146

Merged
merged 2 commits into from May 7, 2024

Conversation

CristianAmbrosini
Copy link
Contributor

@CristianAmbrosini CristianAmbrosini commented Apr 19, 2024

The search "sonar dotnet" only reports the scanner, whereas "sonar" also returns the CSharp analyzer in the first position.
Adding more tags would help discoverability on nuget.org.

See original ticket here.

Tested in https://int.nugettest.org/

Resources:

Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@CristianAmbrosini CristianAmbrosini marked this pull request as ready for review May 6, 2024 07:33
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban May 6, 2024
@CristianAmbrosini CristianAmbrosini enabled auto-merge (squash) May 6, 2024 08:50
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, I found this, which claims that we no longer need the .nuspec file. Did you look into that?
Right now, the tags are duplicated, which is not optimal.

@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban May 6, 2024
@CristianAmbrosini
Copy link
Contributor Author

LGTM. However, I found this, which claims that we no longer need the .nuspec file. Did you look into that? Right now, the tags are duplicated, which is not optimal.

I was not able to find more references. Anyway, nuspec tags where already there, I just extended the list. I think we can keep it like this for now, the duplication (if any) should not be that big of a deal anyway in my opinion

Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@CristianAmbrosini CristianAmbrosini merged commit 97d7805 into master May 7, 2024
34 checks passed
Best Kanban automation moved this from Review approved to Validate Peach May 7, 2024
@CristianAmbrosini CristianAmbrosini deleted the cristian/improve-discoverability branch May 7, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Best Kanban
  
Validate Peach
Development

Successfully merging this pull request may close these issues.

None yet

2 participants