Disjoint Sets primitives

[antonioaversa]

Part of #9089

[antonioaversa]

@mary-georgiou-sonarsource @gregory-paidis-sonarsource Regarding this issue on SonarCloud: the result of DisjointSets has to be predictable. Therefore, order is important, and that's why I used a List, for both inner and outer structures.

Wrapping the inner list into a non-generic structure to fix the issue, in my opinion, will make the code that manipulates the structure more complex and less clear. So I would declare the issue as Wont Fix.

[gregory-paidis-sonarsource]

Very nice testcases!
Left a few comments, mostly optional and questions.

[mary-georgiou-sonarsource]

It's super clear what this code is doing and it's very elegant.
However, I feel like when I see it it's not part of this codebase somehow.

If I read it without any context, I would have a hard time getting a quick idea of where it can be used and what its purpose is in the context of sonar-dotnet.

Maybe it's better to create a base class analyzer called "FindClassCodepedencies" or something similar, and then we can extend this class for every rule that needs this functionality.

WDYT? this is a question also for @gregory-paidis-sonarsource

[mary-georgiou-sonarsource]

I'd add a comment here explaining a bit about the purpose of the class and these methods in the context of sonar-dotnet.

[gregory-paidis-sonarsource]

Left only one comment, about how to utilize this class.

[gregory-paidis-sonarsource]

LGTM

[mary-georgiou-sonarsource]

LGTM

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[sonarcloud]

Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud