Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SonarAnalyzer.CSharp.Styling project #9048

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

pavel-mikula-sonarsource
Copy link
Contributor

Fixes #9032

@pavel-mikula-sonarsource pavel-mikula-sonarsource added this to the 9.24 milestone Apr 9, 2024
@github-actions github-actions bot added this to To do in Best Kanban Apr 9, 2024
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 9, 2024

<ItemGroup>
<!-- We need to update NuGet and JAR packaging after changing references -->
<ProjectReference Include="..\SonarAnalyzer.Common\SonarAnalyzer.Common.csproj" />
<ProjectReference Include="..\SonarAnalyzer.Common\SonarAnalyzer.CSharp.csproj" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path is wrong. It is fixed in the next PR

Suggested change
<ProjectReference Include="..\SonarAnalyzer.Common\SonarAnalyzer.CSharp.csproj" />
<ProjectReference Include="..\SonarAnalyzer.CSharp\SonarAnalyzer.CSharp.csproj" />

Copy link
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sebastien-marichal sebastien-marichal merged commit e518a59 into master Apr 9, 2024
32 checks passed
Best Kanban automation moved this from To do to Validate Peach Apr 9, 2024
@sebastien-marichal sebastien-marichal deleted the Pavel/Styling branch April 9, 2024 11:50
@sebastien-marichal sebastien-marichal moved this from Validate Peach to Done in Best Kanban Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Best Kanban
  
Done
Development

Successfully merging this pull request may close these issues.

Create SonarAnalyzer.CSharp.Styling project
2 participants