Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SyntaxNodeExtensions: increase GetBody coverage #8639

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

SyntaxNodeExtensions: increase GetBody coverage #8639

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4ded29d
SyntaxNodeExtensions: increase GetBody coverage
antonioaversa Jan 30, 2024
9ebc49d
Fix naming
antonioaversa Jan 30, 2024
827f6e0
Add missing UTs in local functions
antonioaversa Jan 30, 2024
edc5423
Code review 1
antonioaversa Jan 30, 2024
3d1f73a
Code review 2
antonioaversa Jan 30, 2024
91a5f26
Code review 3
antonioaversa Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
53 changes: 52 additions & 1 deletion analyzers/tests/SonarAnalyzer.Test/Extensions/SyntaxNodeExtensionsTest.cs
View file
Open in desktop
Expand Up @@ -23,6 +23,7 @@

using FluentAssertions.Extensions;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.Operations;
using Microsoft.CodeAnalysis.Text;
using SonarAnalyzer.CFG.Roslyn;
Expand Down Expand Up @@ -172,6 +173,56 @@ public void ArrowExpressionBody_WithNotExpectedNode_ReturnsNull()
public void GetDeclarationTypeName_Struct() =>
ExtensionsCS.GetDeclarationTypeName(SyntaxFactory.StructDeclaration("MyStruct")).Should().Be("struct");

[TestMethod]
public void GetBody_FieldDeclaration()
{
ExtensionsCS.GetBody(SyntaxFactory.FieldDeclaration(SyntaxFactory.VariableDeclaration(SyntaxFactory.ParseTypeName("int")))).Should().BeNull();
}

[TestMethod]
public void GetBody_PropertyDeclaration_SingleAccessor()
{
var code = "class AClass { int AProperty { get => 42; } }";
ExtensionsCS.GetBody(CSharpSyntaxTree.ParseText(code).Single<PropertyDeclarationSyntax>()).Should().BeNull();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExtensionsCS.GetBody(CSharpSyntaxTree.ParseText(code).Single<T> is repeated very often. Extract a helper

BlockSyntax ParseForBlockSyntax<T>(string code) where T: CSharpSyntaxNode
    => ExtensionsCS.GetBody(CSharpSyntaxTree.ParseText(code).Single<T>());

}

[TestMethod]
public void GetBody_PropertyDeclaration_MultipleAccessors()
{
var code = "class AClass { int AProperty { get => 42; set { } } }";
ExtensionsCS.GetBody(CSharpSyntaxTree.ParseText(code).Single<PropertyDeclarationSyntax>()).Should().BeNull();
}

[TestMethod]
public void GetBody_AccessorDeclaration_ArrowExpression()
{
var code = "class AClass { int AProperty { get => 42; } }";
ExtensionsCS.GetBody(CSharpSyntaxTree.ParseText(code).Single<AccessorDeclarationSyntax>()).Should().BeNull();
}

[TestMethod]
public void GetBody_AccessorDeclaration_BodyBlock()
{
var code = "class AClass { int AProperty { set { var x1; var x2; var x3; } } }";
martin-strecker-sonarsource marked this conversation as resolved.
Show resolved Hide resolved
ExtensionsCS.GetBody(CSharpSyntaxTree.ParseText(code).Single<AccessorDeclarationSyntax>())
.Should().BeOfType<BlockSyntax>().Which.Statements.Should().HaveCount(3);
}

[TestMethod]
public void GetBody_LocalFunctionStatement_ArrowExpression()
{
var code = "class AClass { void AMethod() { int ALocalFunction() => 42; } }";
ExtensionsCS.GetBody(CSharpSyntaxTree.ParseText(code).Single<LocalFunctionStatementSyntax>()).Should().BeNull();
}

[TestMethod]
public void GetBody_LocalFunctionStatement_BodyBlock()
{
var code = "class AClass { void AMethod() { int ALocalFunction() { var x1; var x2; var x3; return 42; } } }";
martin-strecker-sonarsource marked this conversation as resolved.
Show resolved Hide resolved
ExtensionsCS.GetBody(CSharpSyntaxTree.ParseText(code).Single<LocalFunctionStatementSyntax>())
.Should().BeOfType<BlockSyntax>().Which.Statements.Should().HaveCount(4);
}
martin-strecker-sonarsource marked this conversation as resolved.
Show resolved Hide resolved

[TestMethod]
public void CreateCfg_MethodDeclaration_ReturnsCfg_CS()
{
Expand Down Expand Up @@ -230,7 +281,7 @@ public void CreateCfg_FieldInitializerWithoutOperation_ReturnsCfg_CS()
const string code = """
public class Sample
{
private string field = null!; // null! itself doens't have operation, and we can still generate CFG for it from the equals clause
private string field = null!; // null! itself doesn't have operation, and we can still generate CFG for it from the equals clause
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have an operation

}
""";
CreateCfgCS<SyntaxCS.EqualsValueClauseSyntax>(code).Should().NotBeNull();
Expand Down