-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reproducers for S1144 FN/FP #7925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left one comment.
@@ -119,4 +120,15 @@ private record PrivateRecordRef | |||
[DllImport("user32.dll")] | |||
private static extern bool ExternalMethod(ref PrivateRecordRef reference); | |||
} | |||
|
|||
// https://github.com/SonarSource/sonar-dotnet/issues/7904 | |||
public sealed record Repro_7904 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the following test case as well, to make sure when the FP is fixed it won't create new FNs:
public class ClassWithPrintMembersMethod
{
private bool PrintMembers(StringBuilder builder) // Noncompliant
{
return true;
}
}
Kudos, SonarCloud Quality Gate passed! |
Kudos, SonarCloud Quality Gate passed! |
Add reproducers for: