SE: Learn bool constraints from Equals with bool parameters. #7899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-georgiou-sonarsource
force-pushed
the
mary/equals-constraints
branch
from
37d3697
to
91021ef
Compare
mary-georgiou-sonarsource
force-pushed
the
mary/equals-constraints
branch
from
91021ef
to
534ba98
Compare
mary-georgiou-sonarsource
added
the
Sprint: SE
mary-georgiou-sonarsource
moved this from In progress
to Review in progress
in Best Kanban
mary-georgiou-sonarsource
assigned Tim-Pohlmann and unassigned mary-georgiou-sonarsource
mary-georgiou-sonarsource
force-pushed
the
mary/equals-constraints
branch
from
c75f851
to
2cb7967
Compare
Tim-Pohlmann
requested changes
Aug 25, 2023
analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/Invocation.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/Invocation.cs
Outdated
Show resolved
Hide resolved
...ts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs
Outdated
Show resolved
Hide resolved
...ts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs
Outdated
Show resolved
Hide resolved
...ts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs
Outdated
Show resolved
Hide resolved
...ts/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.cs
Outdated
Show resolved
Hide resolved
mary-georgiou-sonarsource
force-pushed
the
mary/equals-constraints
branch
from
0236d39
to
f00822d
Compare
mary-georgiou-sonarsource
force-pushed
the
mary/equals-constraints
branch
from
7b0a310
to
35e9340
Compare
Tim-Pohlmann
requested changes
Aug 28, 2023
analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/Invocation.cs
Outdated
Show resolved
Hide resolved
...ts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+970
to
+974
| [DataTestMethod] | ||
| [DataRow("true", "null", false)] | ||
| [DataRow("null", "true", false)] | ||
| [DataRow("null", "(bool?)true", false)] | ||
| public void Invocation_ObjectEqualsMixedNullObjectArguments_LearnResult(string left, string right, bool expectedResult) |
There was a problem hiding this comment.
I think you can just incorporate this into Invocation_BoolEquals_LearnsResult.
There was a problem hiding this comment.
It calls ObjectEquals and tests this method's behavior in practice - but it's not easy to incorporate into ObjectEquals either :/
There was a problem hiding this comment.
Maybe just add it to Invocation_ObjectEquals_LearnResult then.
There was a problem hiding this comment.
It's not straightforward - as discussed will leave as is.
...ts/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.cs
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Tim-Pohlmann
approved these changes
Aug 28, 2023
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #7704