SE: Optimize SymbolicCheckList.InvokeChecks #7061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-strecker-sonarsource
added
the
Sprint: SE
martin-strecker-sonarsource
force-pushed
the
Martin/SE_6964_08_InvokeChecksCapacity
branch
from
7c869ca
to
a4ea933
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
|
Closed. #7059 is the favourable approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6964
This is a more simple but also less efficient optimization than #7059. #7059 should be preferred as it allows to simplify the engine as well.
Simple refactoring which results in some modest reduction in allocations for
SonarAnalyzer.SymbolicExecution.Roslyn.SymbolicContext[]. There were some unnecessary array copies taking place because of theToArraycall. The capacity is optimized for the common cases now.The changes for
SonarAnalyzer.SymbolicExecution.Roslyn.SymbolicContext[]are:The change does not have a measurable impact in total (~1% improvement).