S1905: Use NullableAnnotation() to find differences in type annotations #7036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-strecker-sonarsource
changed the title
martin-strecker-sonarsource
added
Type: Improvement
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned martin-strecker-sonarsource
martin-strecker-sonarsource
force-pushed
the
Martin/SE_5217_NullableContext
branch
from
c3e0eb7
to
cfe3865
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
|
@sebastien-marichal This is some slightly older PR that never got the requested review. Please have a look. |
This was referenced Nov 28, 2023
github-actions
bot
assigned martin-strecker-sonarsource and unassigned sebastien-marichal
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
martin-strecker-sonarsource
force-pushed
the
Martin/SE_5217_NullableContext
branch
from
cfe3865
to
bee8c0d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
martin-strecker-sonarsource
deleted the
Martin/SE_5217_NullableContext
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6825
This PR lights up NullableAnnotation() for all symbols that support this property. It also adds the missing usage in RedundantCast that motivated #6825.
The PR was started by working on #5217 which was postponed until later.