Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITs: Deduplicate orchestrator initialization #7017

Merged
merged 4 commits into from Mar 31, 2023

Conversation

pavel-mikula-sonarsource
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource commented Mar 31, 2023

Deduplicate version configuration and orchestrator scaffolding to a single place.

@pavel-mikula-sonarsource pavel-mikula-sonarsource changed the title ITs: Use SQ DEV, deduplicate initialization ITs: Use SQ DEV, deduplicate orchestrator initialization Mar 31, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource changed the title ITs: Use SQ DEV, deduplicate orchestrator initialization ITs: Deduplicate orchestrator initialization Mar 31, 2023
// The SonarQube alias "LTS" has been dropped. An alternative is "LATEST_RELEASE[6.7]".
// The term "latest" refers to the highest version number, not the most recently published version.
public static String replaceLtsVersion(String version) {
if (version != null && version.equals("LTS")) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use the old "LTS" value anywhere. And we don't need to => we don't need this functionality.

Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only a comment regarding a a comment in the code that is not clear to me.

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 2226aa4 into master Mar 31, 2023
24 checks passed
Best Kanban automation moved this from Review approved to Validate Peach Mar 31, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Pavel/Orchestrator branch March 31, 2023 13:28
@pavel-mikula-sonarsource pavel-mikula-sonarsource added the Sprint: SE Short-lived* label for epic MMF-3077 *troll label Apr 3, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource moved this from Validate Peach to Done in Best Kanban Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprint: SE Short-lived* label for epic MMF-3077 *troll
Projects
Best Kanban
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants