Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S3398: Replace SyntaxWalker with SafeSyntaxWalker #6852

Merged
merged 1 commit into from Mar 3, 2023
Merged

Fix S3398: Replace SyntaxWalker with SafeSyntaxWalker #6852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions analyzers/src/SonarAnalyzer.CSharp/Rules/PrivateStaticMethodUsedOnlyByNestedClass.cs
View file
Open in desktop
Expand Up @@ -134,7 +134,7 @@ private static TypeDeclarationSyntax LowestCommonAncestorOrSelf(IEnumerable<Type
IEnumerable<MethodDeclarationSyntax> methods, TypeDeclarationSyntax outerType, SemanticModel model)
{
var collector = new PotentialMethodReferenceCollector(methods);
collector.Visit(outerType);
collector.SafeVisit(outerType);

return collector.PotentialMethodReferences
.Where(x => !OnlyUsedByOuterType(x))
Expand Down Expand Up @@ -181,7 +181,7 @@ private sealed record MethodUsedByTypes(MethodDeclarationSyntax Method, TypeDecl
/// Performance gains: by only using the syntax tree to find matches we can eliminate certain methods (which are only used by the type which has declared it)
/// without using the more costly symbolic lookup.
/// </summary>
private sealed class PotentialMethodReferenceCollector : CSharpSyntaxWalker
private sealed class PotentialMethodReferenceCollector : SafeCSharpSyntaxWalker
{
private readonly ISet<MethodDeclarationSyntax> methodsToFind;
private readonly Dictionary<MethodDeclarationSyntax, List<IdentifierNameSyntax>> potentialMethodReferences;
Expand Down