Make KnownType class and fields public, to make it usable in SyntaxFacade #6760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The
KnownType
class, defined inSonarAnalyzer.Common
isinternal
, as well as the long list of itsstatic readonly KnownType
fields.The implementation of #6703 (#6728) required adding a new method to the
SyntaxFacade
class (c.p. #6728 (comment)):SyntaxFacade
is a public class implemented byCSharpSyntaxFacade
, inSonarAnalyzer.CSharp
, and byVisualBasicSyntaxFacade
inSonarAnalyzer.VisualBasic
.This PR solves the accessibility inconsistency that adding
IsKnownAttribute
toSyntaxFacade
would produce.The change, originally made in #6703, has been isolated into this PR to keep the git history clear.