Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S1905 FP: Nullability context and array of anonymous types #6753

Merged
merged 23 commits into from Mar 14, 2023
Merged

Fix S1905 FP: Nullability context and array of anonymous types #6753

merged 23 commits into from Mar 14, 2023

Commits on Mar 1, 2023

  1. Add FP test cases

    @Tim-Pohlmann
    Tim-Pohlmann committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    56a5ca2 View commit details
    Browse the repository at this point in the history

  2. Clean up some code

    @Tim-Pohlmann
    Tim-Pohlmann committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    fa0d931 View commit details
    Browse the repository at this point in the history

  3. Add check for anaonymous objects in implicit arrays and switch expres… 

    …sions
    @Tim-Pohlmann
    Tim-Pohlmann committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    2ce6132 View commit details
    Browse the repository at this point in the history

  4. Improve pattern matching

    @Tim-Pohlmann
    Tim-Pohlmann committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    655120e View commit details
    Browse the repository at this point in the history

  5. Fix a newly introduced FN

    @Tim-Pohlmann
    Tim-Pohlmann committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    12e5164 View commit details
    Browse the repository at this point in the history

  6. Change approach to check for Nullability

    @Tim-Pohlmann
    Tim-Pohlmann committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    f87cadd View commit details
    Browse the repository at this point in the history

  7. Change code to use FlowState when available

    @Tim-Pohlmann
    Tim-Pohlmann committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    eaa9553 View commit details
    Browse the repository at this point in the history

  8. Refactor and improve tests

    @Tim-Pohlmann
    Tim-Pohlmann committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    c85f588 View commit details
    Browse the repository at this point in the history

  9. Clean up CheckCastExpression

    @Tim-Pohlmann
    Tim-Pohlmann committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    cbb4a49 View commit details
    Browse the repository at this point in the history

  10. Update analyzers/src/SonarAnalyzer.CSharp/Rules/RedundantCast.cs 

    Co-authored-by: Martin Strecker <103252490+martin-strecker-sonarsource@users.noreply.github.com>
    @Tim-Pohlmann @martin-strecker-sonarsource
    Tim-Pohlmann and martin-strecker-sonarsource committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    92fe174 View commit details
    Browse the repository at this point in the history

  11. Update analyzers/src/SonarAnalyzer.CSharp/Rules/RedundantCast.cs 

    Co-authored-by: Martin Strecker <103252490+martin-strecker-sonarsource@users.noreply.github.com>
    @Tim-Pohlmann @martin-strecker-sonarsource
    Tim-Pohlmann and martin-strecker-sonarsource committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    cdf4780 View commit details
    Browse the repository at this point in the history

  12. Update analyzers/src/SonarAnalyzer.CSharp/Rules/RedundantCast.cs 

    Co-authored-by: Martin Strecker <103252490+martin-strecker-sonarsource@users.noreply.github.com>
    @Tim-Pohlmann @martin-strecker-sonarsource
    Tim-Pohlmann and martin-strecker-sonarsource committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    8a5b500 View commit details
    Browse the repository at this point in the history

  13. Fixe wrong parameter order

    @Tim-Pohlmann
    Tim-Pohlmann committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    ab8ecd8 View commit details
    Browse the repository at this point in the history

  14. Refactor some code and add tests for as expressions

    @Tim-Pohlmann
    Tim-Pohlmann committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    b3db542 View commit details
    Browse the repository at this point in the history

  15. Improve code

    @Tim-Pohlmann
    Tim-Pohlmann committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    05578e3 View commit details
    Browse the repository at this point in the history

  16. Refactor GetElementType

    @Tim-Pohlmann
    Tim-Pohlmann committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    2d51c5f View commit details
    Browse the repository at this point in the history

  17. Add more tests

    @Tim-Pohlmann
    Tim-Pohlmann committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    11d61ce View commit details
    Browse the repository at this point in the history

  18. Use Is(KnownType...) instead of name check

    @Tim-Pohlmann
    Tim-Pohlmann committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    aae24ab View commit details
    Browse the repository at this point in the history

  19. Simplify GetReportLocation

    @Tim-Pohlmann
    Tim-Pohlmann committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    28ddab0 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Add more tests, including FNs

    @Tim-Pohlmann
    Tim-Pohlmann committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    943592d View commit details
    Browse the repository at this point in the history

  2. Fix FP

    @Tim-Pohlmann
    Tim-Pohlmann committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    95278ed View commit details
    Browse the repository at this point in the history

  3. Simplify code

    @Tim-Pohlmann
    Tim-Pohlmann committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    3a1197c View commit details
    Browse the repository at this point in the history

  4. Remove CodeSmell

    @Tim-Pohlmann
    Tim-Pohlmann committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    f8abb8d View commit details
    Browse the repository at this point in the history