Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S2198 FP: Exclude Infinity checks #6749

Merged
merged 1 commit into from Feb 13, 2023
Merged

Fix S2198 FP: Exclude Infinity checks #6749

merged 1 commit into from Feb 13, 2023

Conversation

gregory-paidis-sonarsource
Copy link
Contributor

@gregory-paidis-sonarsource gregory-paidis-sonarsource commented Feb 13, 2023 •
edited by antonioaversa

Relates to #6658

Example FP

Generally looks like:

const float i = float.PositiveInfinity;
float x = 42;
_ = 42 >= i; // Should NOT raise

@github-actions github-actions bot added this to In progress in Best Kanban Feb 13, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gregory-paidis-sonarsource gregory-paidis-sonarsource marked this pull request as ready for review February 13, 2023 09:26
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Feb 13, 2023
martin-strecker-sonarsource
martin-strecker-sonarsource approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Best Kanban automation moved this from Review in progress to Review approved Feb 13, 2023
@gregory-paidis-sonarsource gregory-paidis-sonarsource merged commit 32343e3 into master Feb 13, 2023
Best Kanban automation moved this from Review approved to Validate Peach Feb 13, 2023
@gregory-paidis-sonarsource gregory-paidis-sonarsource deleted the greg/fix-S2198-FP branch February 13, 2023 11:37
@gregory-paidis-sonarsource gregory-paidis-sonarsource moved this from Validate Peach to Done in Best Kanban Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-strecker-sonarsource martin-strecker-sonarsource martin-strecker-sonarsource approved these changes

Assignees

@gregory-paidis-sonarsource gregory-paidis-sonarsource

Labels
None yet
Projects
Best Kanban
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gregory-paidis-sonarsource @martin-strecker-sonarsource