Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New rule S2166: Classes named like "Exception" should extend "Exception" or a subclass #6727
New rule S2166: Classes named like "Exception" should extend "Exception" or a subclass #6727
Changes from 5 commits
12c49d4
43d058f
78dd3fc
b2d8e63
da7f219
af479a1
a8e4e12
5215eca
6818afe
fb60d96
c49813e
df85f92
8d95675
3a755e4
540c20b
8b1e18b
5715d6d
fa18201
0ad6700
044ce8b
8e0317d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This using seems unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to ignore this remark if you disagree.
If I understand well, this disables the rule for static classes.
Why would you think it's appropriate, for static classes, to have a name ending in
Exception
? To me, that seems to violate the principle of least astonishment.As for addressing the issue in this scenario: while you can't inherit from
Exception
, you can still rename the class and remove the suffix.The same reasoning would also apply to
Module
, in my opinion.As for
struct
,enum
andrecord struct
: seems OK to me to not consider them in this rule, as it mentionsclass
in its title (although the other languages for which the rule is implemented, namely Java and PHP, don't have to distinguish on such cases).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I changed the test cases to reflect this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
builderCS
should go to the new line.Same in lines below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved them to new lines.