Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S4663: Fix highlighting to remove underlying whitespaces #6725

Merged
merged 2 commits into from Feb 7, 2023
Merged

S4663: Fix highlighting to remove underlying whitespaces #6725

merged 2 commits into from Feb 7, 2023

Conversation

gregory-paidis-sonarsource
Copy link
Contributor

@gregory-paidis-sonarsource gregory-paidis-sonarsource commented Feb 6, 2023 •
edited by antonioaversa

Relates to #6663

This PR aims to fix squiggly lines under whitespace between SingleLineCommentTrivia entries.

Before

image

After

image

@github-actions github-actions bot added this to In progress in Best Kanban Feb 6, 2023
@gregory-paidis-sonarsource gregory-paidis-sonarsource added Type: Improvement Making existing code better. Area: C# C# rules related issues. labels Feb 6, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@gregory-paidis-sonarsource gregory-paidis-sonarsource marked this pull request as ready for review February 6, 2023 14:30
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Feb 6, 2023
@gregory-paidis-sonarsource
Copy link
Contributor Author

@martin-strecker-sonarsource The change was minimal after all, so I decided to fix it.

martin-strecker-sonarsource
martin-strecker-sonarsource approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Best Kanban automation moved this from Review in progress to Review approved Feb 7, 2023
@martin-strecker-sonarsource martin-strecker-sonarsource merged commit b3aeb3c into master Feb 7, 2023
Best Kanban automation moved this from Review approved to Validate Peach Feb 7, 2023
@martin-strecker-sonarsource martin-strecker-sonarsource deleted the greg/fix-S4663-secondary-locations branch February 7, 2023 08:38
@gregory-paidis-sonarsource gregory-paidis-sonarsource moved this from Validate Peach to Done in Best Kanban Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-strecker-sonarsource martin-strecker-sonarsource martin-strecker-sonarsource approved these changes

Assignees

@gregory-paidis-sonarsource gregory-paidis-sonarsource

Labels
Area: C# C# rules related issues. Type: Improvement Making existing code better.
Projects
Best Kanban
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gregory-paidis-sonarsource @martin-strecker-sonarsource