Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule S3063: "StringBuilder" data should be used #6696

Merged
merged 41 commits into from Feb 14, 2023
Merged

New rule S3063: "StringBuilder" data should be used #6696

merged 41 commits into from Feb 14, 2023

Commits on Feb 7, 2023

  1. Base

    @CristianAmbrosini
    CristianAmbrosini committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    c99b62c View commit details
    Browse the repository at this point in the history

  2. Add test cases

    @CristianAmbrosini
    CristianAmbrosini committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    08f0ba3 View commit details
    Browse the repository at this point in the history

  3. First implementation CS/VB

    @CristianAmbrosini
    CristianAmbrosini committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    b7d0d30 View commit details
    Browse the repository at this point in the history

  4. Fix UTs

    @CristianAmbrosini
    CristianAmbrosini committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    e487913 View commit details
    Browse the repository at this point in the history

  5. Fixed code smells + added test cases

    @CristianAmbrosini
    CristianAmbrosini committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    7ddcd31 View commit details
    Browse the repository at this point in the history

  6. More test cases

    @CristianAmbrosini
    CristianAmbrosini committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    1dee716 View commit details
    Browse the repository at this point in the history

  7. Fixed CS test cases

    @CristianAmbrosini
    CristianAmbrosini committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    b4c1029 View commit details
    Browse the repository at this point in the history

  8. Fixed VB test cases

    @CristianAmbrosini
    CristianAmbrosini committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    97a2421 View commit details
    Browse the repository at this point in the history

  9. Semplifications

    @CristianAmbrosini
    CristianAmbrosini committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    d2554e6 View commit details
    Browse the repository at this point in the history

  10. Add support for TopLevelStatements and StringBuilder access methods

    @CristianAmbrosini
    CristianAmbrosini committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    740a16e View commit details
    Browse the repository at this point in the history

  11. Add support for null-conditional operator

    @CristianAmbrosini
    CristianAmbrosini committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    85e22ee View commit details
    Browse the repository at this point in the history

  12. Add support for interpolated strings and VB null conditional operators

    @CristianAmbrosini
    CristianAmbrosini committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    e6ce8bd View commit details
    Browse the repository at this point in the history

  13. Avoid raising for field declarations

    @CristianAmbrosini
    CristianAmbrosini committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    59f1967 View commit details
    Browse the repository at this point in the history

  14. Replaced name comparison with semantic model symbol checks

    @CristianAmbrosini
    CristianAmbrosini committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    f0003ba View commit details
    Browse the repository at this point in the history

  15. Add support for indexer access

    @CristianAmbrosini
    CristianAmbrosini committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    c062371 View commit details
    Browse the repository at this point in the history

  16. Add syntax kind

    @CristianAmbrosini
    CristianAmbrosini committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    f44dc07 View commit details
    Browse the repository at this point in the history

  17. Fix UTs

    @CristianAmbrosini
    CristianAmbrosini committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    c207c32 View commit details
    Browse the repository at this point in the history

  18. Rewritten IsSameVariable to improve performance

    @CristianAmbrosini
    CristianAmbrosini committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    226bfdf View commit details
    Browse the repository at this point in the history

  19. Removed comments

    @CristianAmbrosini
    CristianAmbrosini committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    73ca43b View commit details
    Browse the repository at this point in the history

  20. Improved perf on IsSameVariable (VB)

    @CristianAmbrosini
    CristianAmbrosini committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    344e472 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Addressed PR comments

    @CristianAmbrosini
    CristianAmbrosini committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    0830d34 View commit details
    Browse the repository at this point in the history

  2. Rule structure changes

    @CristianAmbrosini
    CristianAmbrosini committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    77a23a1 View commit details
    Browse the repository at this point in the history

  3. Increased performance checking var names before syntax level check

    @CristianAmbrosini
    CristianAmbrosini committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    7da66e4 View commit details
    Browse the repository at this point in the history

  4. Increased perf skipping not interesting SyntaxKinds

    @CristianAmbrosini
    CristianAmbrosini committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    7c96800 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Add coverage amd fix code smell

    @CristianAmbrosini
    CristianAmbrosini committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    a26ea27 View commit details
    Browse the repository at this point in the history

  2. ITs fix

    @CristianAmbrosini
    CristianAmbrosini committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    df5dc9c View commit details
    Browse the repository at this point in the history

  3. Address PR comments

    @CristianAmbrosini
    CristianAmbrosini committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    ba38024 View commit details
    Browse the repository at this point in the history

  4. Raise for .Capacity and .MaxCapacity

    @CristianAmbrosini
    CristianAmbrosini committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    76383c1 View commit details
    Browse the repository at this point in the history

  5. Small tweaks

    @CristianAmbrosini
    CristianAmbrosini committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    2ac2907 View commit details
    Browse the repository at this point in the history

  6. Removed support for Null-conditional operators ?.

    @CristianAmbrosini
    CristianAmbrosini committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    716a82d View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Addressed more PR comments

    @CristianAmbrosini
    CristianAmbrosini committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    408e5fa View commit details
    Browse the repository at this point in the history

  2. TryCreate code clean up

    @CristianAmbrosini
    CristianAmbrosini committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    5ba0b53 View commit details
    Browse the repository at this point in the history

  3. Added support for assignments

    @CristianAmbrosini
    CristianAmbrosini committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    232c216 View commit details
    Browse the repository at this point in the history

  4. Added FP

    @CristianAmbrosini
    CristianAmbrosini committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    add749b View commit details
    Browse the repository at this point in the history

  5. Add link to the issue

    @CristianAmbrosini
    CristianAmbrosini committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    424f743 View commit details
    Browse the repository at this point in the history

  6. Fix code smell

    @CristianAmbrosini
    CristianAmbrosini committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    95e9522 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. Address review comments

    @CristianAmbrosini
    CristianAmbrosini committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    a6b6c98 View commit details
    Browse the repository at this point in the history

  2. More comments

    @CristianAmbrosini
    CristianAmbrosini committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    498e6f0 View commit details
    Browse the repository at this point in the history

  3. && to ||

    @CristianAmbrosini
    CristianAmbrosini committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    0d2733e View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Remove GetIdentifier from the Facade (not used in the current rule im… 

    …plementation)
    @CristianAmbrosini
    CristianAmbrosini committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    aaa0754 View commit details
    Browse the repository at this point in the history

  2. Removed from the interface

    @CristianAmbrosini
    CristianAmbrosini committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    d60927c View commit details
    Browse the repository at this point in the history