Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule S2198: Silly mathematical comparisons should not be made #6695

Merged
merged 28 commits into from Feb 10, 2023
Merged

New rule S2198: Silly mathematical comparisons should not be made #6695

merged 28 commits into from Feb 10, 2023

Commits on Feb 1, 2023

  1. Update RSPEC for S2198

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    e76d32a View commit details
    Browse the repository at this point in the history

  2. Remove a useless auto-generated json

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    93391b2 View commit details
    Browse the repository at this point in the history

  3. Add some testcases

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    ececfa2 View commit details
    Browse the repository at this point in the history

  4. Remove a useless using

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    46f3d70 View commit details
    Browse the repository at this point in the history

  5. Initial implementation of the main logic

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    5bdd084 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Initial working implementation of S2198

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    fee626d View commit details
    Browse the repository at this point in the history

  2. Refactor implementation

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    36214a2 View commit details
    Browse the repository at this point in the history

  3. Move some code around

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    2983cc7 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. Add a lot of testcases

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    3374a35 View commit details
    Browse the repository at this point in the history

  2. Cut branches: only implement absolute inequality for float

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    3564d52 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Rewrite SillyMathematicalComparison, only out-of-range checks for flo… 

    …ats for this step
    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    86696dc View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Apply PR review changes

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    99f3b27 View commit details
    Browse the repository at this point in the history

  2. Enrichen testcases, add long and ulong to the checked types

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    ee45a5c View commit details
    Browse the repository at this point in the history

  3. Add 'is' pattern testcases, refactored a .ToString to a .ToDisplayString

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    ba6589f View commit details
    Browse the repository at this point in the history

  4. Simple rename

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    d463864 View commit details
    Browse the repository at this point in the history

  5. Implement a constant-in-both-sides version of the rule.

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    4f0720a View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Apply PR Review changes, some constant-check fixes and more testcases

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    0070a96 View commit details
    Browse the repository at this point in the history

  2. Add enum, char and reference type to the testcases

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    e3b6f24 View commit details
    Browse the repository at this point in the history

  3. Simplify the rule, only care about out-of-range mathematical checks

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    a84d441 View commit details
    Browse the repository at this point in the history

  4. Add char out-of-range detection

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    4856e96 View commit details
    Browse the repository at this point in the history

  5. Added some true negatives for const1 {{operator}} const2

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    51d7b9c View commit details
    Browse the repository at this point in the history

  6. Bump coverage by adding a case I forgot about

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    f79b42a View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Apply PR Review changes

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    083ae47 View commit details
    Browse the repository at this point in the history

  2. Add an is-pattern edgecase in the testcases

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    0980aa4 View commit details
    Browse the repository at this point in the history

  3. Fix a logical condition, refactor TryGetRange

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    16c517c View commit details
    Browse the repository at this point in the history

  4. Minor naming refactor

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    a0fd1ce View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Minor refactor for OutOfRange check

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    339ac49 View commit details
    Browse the repository at this point in the history

  2. Annotate a testcase with an issue

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    a8f25d7 View commit details
    Browse the repository at this point in the history