Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule S4663: Comments should not be empty #6672

Merged
merged 27 commits into from Feb 3, 2023
Merged

New rule S4663: Comments should not be empty #6672

merged 27 commits into from Feb 3, 2023

Commits on Feb 2, 2023

  1. rspec scaffolding

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    d60e343 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary usings

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    7bc733e View commit details
    Browse the repository at this point in the history

  3. Create initial skeleton for logic

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    697938d View commit details
    Browse the repository at this point in the history

  4. Implement the simplest case and some testcases, minor refactoring

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    3b6e421 View commit details
    Browse the repository at this point in the history

  5. Implement single-line documentation comments

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    270b503 View commit details
    Browse the repository at this point in the history

  6. Add Comment SyntaxTrivia Kinds on the Facades

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    397f3ce View commit details
    Browse the repository at this point in the history

  7. Refactor CommentsShouldNotBeEmpty

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    c6e1155 View commit details
    Browse the repository at this point in the history

  8. Add a lot of testcases for CommentsShouldNotBeEmpty (C#)

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    044dc98 View commit details
    Browse the repository at this point in the history

  9. Minor changes on S4663 C# Testcases

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    a79ff10 View commit details
    Browse the repository at this point in the history

  10. Minor refactoring on S4663 (C#)

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    de69307 View commit details
    Browse the repository at this point in the history

  11. Add testcases for S4663 VB.NET

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    cafb38d View commit details
    Browse the repository at this point in the history

  12. Happy New Year for S4663

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    d235534 View commit details
    Browse the repository at this point in the history

  13. Remove empty line

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    b98189a View commit details
    Browse the repository at this point in the history

  14. Refactor the logic of S4663

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    aa9eab5 View commit details
    Browse the repository at this point in the history

  15. Add a lot of testcases for S4663

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    d76e0d4 View commit details
    Browse the repository at this point in the history

  16. Update dotnet ITs expected for Ember

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    2337881 View commit details
    Browse the repository at this point in the history

  17. Apply PR Review Changes

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    0ad4cff View commit details
    Browse the repository at this point in the history

  18. Appy PR Review changes

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    f8492a9 View commit details
    Browse the repository at this point in the history

  19. Move some logic to the base for S4663

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    7e1b658 View commit details
    Browse the repository at this point in the history

  20. Apply some more PR Review changes

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    3430d93 View commit details
    Browse the repository at this point in the history

  21. Move some members of the facades in the correct alphabetical order

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    80c0476 View commit details
    Browse the repository at this point in the history

  22. Refactor partitioner of S4663 and minor refactor on a helper

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    aed82c6 View commit details
    Browse the repository at this point in the history

  23. Inline a simple local function

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    12daa6e View commit details
    Browse the repository at this point in the history

  24. Final PR Review changes

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    61b9263 View commit details
    Browse the repository at this point in the history

  25. Add some whitespace that i removed

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    c21c1f2 View commit details
    Browse the repository at this point in the history

  26. Move some members of the VB facade around

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    0994b95 View commit details
    Browse the repository at this point in the history

  27. Move two SyntaxKinds in the correct alphabetical order in the C# Facade

    @gregory-paidis-sonarsource
    gregory-paidis-sonarsource committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    99f9c80 View commit details
    Browse the repository at this point in the history