Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule S3878: Arrays should not be created for params parameters #6666

Merged
merged 40 commits into from Feb 1, 2023
Merged

New rule S3878: Arrays should not be created for params parameters #6666

merged 40 commits into from Feb 1, 2023

Commits on Jan 27, 2023

  1. RSPEC baseline

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    05a79ca View commit details
    Browse the repository at this point in the history

  2. Packaging test

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    ca10a13 View commit details
    Browse the repository at this point in the history

  3. Rule file creation, baseline

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    c67118e View commit details
    Browse the repository at this point in the history

  4. First batch of test cases

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    9acb038 View commit details
    Browse the repository at this point in the history

  5. First rule sketch with test cases (cs/vb)

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    6f0f2e5 View commit details
    Browse the repository at this point in the history

  6. Common code to baseclass

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    08d227d View commit details
    Browse the repository at this point in the history

  7. Move semanticModel queries after syntax checks

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    eebe4d4 View commit details
    Browse the repository at this point in the history

  8. Add test case

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    044fd0d View commit details
    Browse the repository at this point in the history

  9. Fix some code smell

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    0916ce7 View commit details
    Browse the repository at this point in the history

  10. Update the list of expected issues

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    c556aa3 View commit details
    Browse the repository at this point in the history

  11. Add support for ObjectCreationExpression

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    cdc92e9 View commit details
    Browse the repository at this point in the history

  12. Add VB test cases

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    41b040c View commit details
    Browse the repository at this point in the history

  13. Defensive checks and fix ITs for ObjectCreation

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    c4f07c6 View commit details
    Browse the repository at this point in the history

  14. Fix code smell

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    1f4ecab View commit details
    Browse the repository at this point in the history

  15. Shared method

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    27b74e9 View commit details
    Browse the repository at this point in the history

  16. Cheching method parameter to fix FN/FP

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    5ba1351 View commit details
    Browse the repository at this point in the history

  17. Fixed CSharp constructor named argument FP

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    a2db8b6 View commit details
    Browse the repository at this point in the history

  18. Small fix

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    469aacd View commit details
    Browse the repository at this point in the history

  19. Rule rewriting, semplifications

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    fa8491c View commit details
    Browse the repository at this point in the history

  20. Removed unused helper class

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    ee448f6 View commit details
    Browse the repository at this point in the history

  21. Added Indexer(CS) and Properties(VB) FN

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    f7b83b1 View commit details
    Browse the repository at this point in the history

  22. Fix UT

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    5517d4f View commit details
    Browse the repository at this point in the history

  23. Second round of comments

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    89d245f View commit details
    Browse the repository at this point in the history

  24. Fix ITs

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    58a200e View commit details
    Browse the repository at this point in the history

  25. Moving stuff to the base class

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    e6b7386 View commit details
    Browse the repository at this point in the history

  26. ParamsInvocationKinds

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    3b890f5 View commit details
    Browse the repository at this point in the history

  27. Code smell fix

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    86f80c5 View commit details
    Browse the repository at this point in the history

  28. Addressed more PR comments

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    055c76d View commit details
    Browse the repository at this point in the history

  29. More restrictive access modifier

    @CristianAmbrosini
    CristianAmbrosini committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    fcc244f View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2023

  1. Add support for implicit object creation expression

    @CristianAmbrosini
    CristianAmbrosini committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    1b4ed98 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. CSharp9 test case with TopLevelStatements

    @CristianAmbrosini
    CristianAmbrosini committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    b6e651e View commit details
    Browse the repository at this point in the history

  2. Removed switch default case

    @CristianAmbrosini
    CristianAmbrosini committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    a9c6530 View commit details
    Browse the repository at this point in the history

  3. Add test case for ArgumentException

    @CristianAmbrosini
    CristianAmbrosini committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    6bcca9e View commit details
    Browse the repository at this point in the history

  4. Standalone ThrowsException tests

    @CristianAmbrosini
    CristianAmbrosini committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    926be7c View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Increased precision for VB

    @CristianAmbrosini
    CristianAmbrosini committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    51095bb View commit details
    Browse the repository at this point in the history

  2. Add coverage for CS ImplicitArrayCreation

    @CristianAmbrosini
    CristianAmbrosini committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    0e31460 View commit details
    Browse the repository at this point in the history

  3. Fix UTs

    @CristianAmbrosini
    CristianAmbrosini committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    5e61ae9 View commit details
    Browse the repository at this point in the history

  4. Fix ITs

    @CristianAmbrosini
    CristianAmbrosini committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    cfab8c1 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Stylistic fix + Noncompliant CS empty array

    @CristianAmbrosini
    CristianAmbrosini committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    d5ce51b View commit details
    Browse the repository at this point in the history

  2. Addressed PR comments

    @CristianAmbrosini
    CristianAmbrosini committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    500870c View commit details
    Browse the repository at this point in the history