Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3415: Add FN repro for #6547 #6613

Merged
merged 9 commits into from Jan 17, 2023
Merged

S3415: Add FN repro for #6547 #6613

merged 9 commits into from Jan 17, 2023

Conversation

cristian-ambrosini-sonarsource
Copy link
Contributor

Test for #6547.

@github-actions github-actions bot added this to In progress in Best Kanban Jan 11, 2023
Open
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Jan 11, 2023
@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban Jan 12, 2023
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Jan 12, 2023
martin-strecker-sonarsource
martin-strecker-sonarsource requested changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the parameterized tests work for each of the frameworks.

...s/tests/SonarAnalyzer.UnitTest/TestCases/AssertionArgsShouldBePassedInCorrectOrder.MsTest.cs Outdated Show resolved Hide resolved
...rs/tests/SonarAnalyzer.UnitTest/TestCases/AssertionArgsShouldBePassedInCorrectOrder.NUnit.cs Outdated Show resolved Hide resolved
...rs/tests/SonarAnalyzer.UnitTest/TestCases/AssertionArgsShouldBePassedInCorrectOrder.Xunit.cs Outdated Show resolved Hide resolved
...rs/tests/SonarAnalyzer.UnitTest/TestCases/AssertionArgsShouldBePassedInCorrectOrder.Xunit.cs Outdated Show resolved Hide resolved
@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban Jan 13, 2023
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource changed the title S3415 - Add repro for #6547 S3415: Add FN repro for #6547 Jan 13, 2023
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Jan 13, 2023
martin-strecker-sonarsource
martin-strecker-sonarsource requested changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the test cases be simplified?

...s/tests/SonarAnalyzer.UnitTest/TestCases/AssertionArgsShouldBePassedInCorrectOrder.MsTest.cs Outdated Show resolved Hide resolved
@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban Jan 13, 2023
@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban Jan 16, 2023
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Jan 16, 2023
martin-strecker-sonarsource
martin-strecker-sonarsource approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @andrei-epure-sonarsource for a second view.

@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Jan 16, 2023
@github-actions github-actions bot moved this from Review approved to Review in progress in Best Kanban Jan 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

andrei-epure-sonarsource
andrei-epure-sonarsource approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@andrei-epure-sonarsource andrei-epure-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Best Kanban automation moved this from Review in progress to Review approved Jan 17, 2023
@andrei-epure-sonarsource andrei-epure-sonarsource merged commit c1e03c5 into master Jan 17, 2023
Best Kanban automation moved this from Review approved to Validate Peach Jan 17, 2023
@andrei-epure-sonarsource andrei-epure-sonarsource deleted the cristian/Repro-6547 branch January 17, 2023 09:20
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource moved this from Validate Peach to Done in Best Kanban Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrei-epure-sonarsource andrei-epure-sonarsource andrei-epure-sonarsource approved these changes

@martin-strecker-sonarsource martin-strecker-sonarsource martin-strecker-sonarsource approved these changes

Assignees

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource

Labels
None yet
Projects
Best Kanban
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cristian-ambrosini-sonarsource @andrei-epure-sonarsource @martin-strecker-sonarsource @CristianAmbrosini