Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S2952 FN/FP: Support conditional invocation and disposal of fields in additional locations #6230

Merged
merged 23 commits into from Feb 21, 2023
Merged

Fix S2952 FN/FP: Support conditional invocation and disposal of fields in additional locations #6230

merged 23 commits into from Feb 21, 2023

Conversation

martin-strecker-sonarsource
Copy link
Contributor

Fixes #5832
Fixes #6229

@martin-strecker-sonarsource martin-strecker-sonarsource changed the title Martin/s2952 conditional member access FN S2952: FNs on conditional invocation Oct 19, 2022
@martin-strecker-sonarsource martin-strecker-sonarsource changed the title FN S2952: FNs on conditional invocation FN S2952: Support conditional invocation Oct 19, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.0% 97.0% Coverage
0.0% 0.0% Duplication

@martin-strecker-sonarsource martin-strecker-sonarsource added this to In progress in Best Kanban via automation Jan 17, 2023
@martin-strecker-sonarsource martin-strecker-sonarsource mentioned this pull request Feb 7, 2023
Merged
@andrei-epure-sonarsource
Copy link
Contributor

@martin-strecker-sonarsource can this be closed?

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource mentioned this pull request Feb 9, 2023
Open
@martin-strecker-sonarsource martin-strecker-sonarsource removed this from In progress in Best Kanban Feb 15, 2023
@martin-strecker-sonarsource martin-strecker-sonarsource marked this pull request as ready for review February 16, 2023 12:31
Tim-Pohlmann
Tim-Pohlmann reviewed Feb 17, 2023
View reviewed changes
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think I understand most of the code. It was a good learning experience.
Comments are mostly minor formatting improvements.

analyzers/src/SonarAnalyzer.CSharp/Extensions/SyntaxNodeExtensions.cs Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/DisposeFromDispose.cs Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/DisposeFromDispose.cs Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/DisposeFromDispose.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/DisposeFromDispose.cs Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/DisposeFromDispose.CSharp7_2.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/DisposeFromDispose.CSharp7_2.cs Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/DisposeFromDispose.CSharp7_2.cs Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/DisposeFromDispose.CSharp9.Part1.cs Outdated Show resolved Hide resolved
analyzers/its/expected/Net5/Net5--net5.0-S2952.json Show resolved Hide resolved
Tim-Pohlmann
Tim-Pohlmann requested changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I need to change "Request changes" for the automation to kick in?

@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.2% 95.2% Coverage
0.0% 0.0% Duplication

@Tim-Pohlmann Tim-Pohlmann mentioned this pull request Feb 17, 2023
Open
@martin-strecker-sonarsource martin-strecker-sonarsource changed the title FN S2952: Support conditional invocation Fix S2952 FN: Support conditional invocation Feb 21, 2023
@martin-strecker-sonarsource martin-strecker-sonarsource changed the title Fix S2952 FN: Support conditional invocation Fix S2952 FN: Support conditional invocation and Disposal of fields in additional locations Feb 21, 2023
@martin-strecker-sonarsource martin-strecker-sonarsource changed the title Fix S2952 FN: Support conditional invocation and Disposal of fields in additional locations Fix S2952 FN/FP: Support conditional invocation and Disposal of fields in additional locations Feb 21, 2023
@martin-strecker-sonarsource martin-strecker-sonarsource changed the title Fix S2952 FN/FP: Support conditional invocation and Disposal of fields in additional locations Fix S2952 FN/FP: Support conditional invocation and disposal of fields in additional locations Feb 21, 2023
@martin-strecker-sonarsource martin-strecker-sonarsource deleted the Martin/S2952_ConditionalMemberAccess branch February 21, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tim-Pohlmann Tim-Pohlmann Tim-Pohlmann approved these changes

Assignees

@martin-strecker-sonarsource martin-strecker-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@martin-strecker-sonarsource @andrei-epure-sonarsource @Tim-Pohlmann