Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Rule T0016: Separate declarations by an empty line #9147

Merged
merged 4 commits into from Apr 24, 2024
Merged

New Rule T0016: Separate declarations by an empty line #9147

merged 4 commits into from Apr 24, 2024

Conversation

pavel-mikula-sonarsource
Copy link
Contributor

Fixes #9130

sebastien-marichal
sebastien-marichal requested changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must admit, it took me a while to review 😅
There is a missing test case.

There is one thing that I didn't quite understand, I left a comment.

analyzers/src/SonarAnalyzer.CSharp.Styling/Rules/SeparateDeclarations.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.CSharp.Styling.Test/TestCases/SeparateDeclarations.cs Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CSharp.Styling/Rules/SeparateDeclarations.cs Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.4% Coverage on New Code
0.4% Duplication on New Code

See analysis details on SonarCloud

sebastien-marichal
sebastien-marichal approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 39a552a into master Apr 24, 2024
29 checks passed
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Pavel/T0016 branch April 24, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastien-marichal sebastien-marichal sebastien-marichal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Rule T0016: Separate declarations by an empty line
2 participants
@pavel-mikula-sonarsource @sebastien-marichal