Add reproducers for S1144 FN/FP #7925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristian-ambrosini-sonarsource
requested a review
from zsolt-kolbay-sonarsource
github-actions
bot
assigned zsolt-kolbay-sonarsource and unassigned cristian-ambrosini-sonarsource
zsolt-kolbay-sonarsource
approved these changes
Aug 30, 2023
| @@ -119,4 +120,15 @@ private record PrivateRecordRef | |||
| [DllImport("user32.dll")] | |||
| private static extern bool ExternalMethod(ref PrivateRecordRef reference); | |||
| } | |||
|
|
|||
| // https://github.com/SonarSource/sonar-dotnet/issues/7904 | |||
| public sealed record Repro_7904 | |||
There was a problem hiding this comment.
Add the following test case as well, to make sure when the FP is fixed it won't create new FNs:
public class ClassWithPrintMembersMethod
{
private bool PrintMembers(StringBuilder builder) // Noncompliant
{
return true;
}
}
github-actions
bot
assigned cristian-ambrosini-sonarsource and unassigned zsolt-kolbay-sonarsource
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reproducers for: