fix issues after rebase - fix test that fails only in debug mode + tr…

…y to increase coverage

analyzers/src/SonarAnalyzer.Common/Extensions/ISymbolExtensions.cs

@@ -151,6 +151,9 @@ public static Accessibility GetEffectiveAccessibility(this ISymbol symbol)
     public static bool IsConstructor(this ISymbol symbol) =>
         symbol.Kind == SymbolKind.Method && symbol.Name == ".ctor";
 
+    public static bool IsStaticConstructor(this ISymbol symbol) =>
+            symbol.Kind == SymbolKind.Method && ((IMethodSymbol)symbol).MethodKind == MethodKind.StaticConstructor;
+
     public static IEnumerable<AttributeData> GetAttributes(this ISymbol symbol, KnownType attributeType) =>
         symbol?.GetAttributes().Where(x => x.AttributeClass.Is(attributeType)) ?? [];
 

analyzers/tests/SonarAnalyzer.Test/Extensions/SyntaxNodeExtensionsTest.cs

@@ -98,7 +98,7 @@ public void ArrowExpressionBody_WithNotExpectedNode_ReturnsNull()
     [TestMethod]
     public void GetDeclarationTypeName_UnknownType() =>
 #if DEBUG
-        Assert.ThrowsException<System.ArgumentException>(() => SyntaxNodeExtensionsCSharp.GetDeclarationTypeName(SyntaxFactory.Block()), "Unexpected type Block\r\nParameter name: kind");
+        Assert.ThrowsException<UnexpectedValueException>(() => SyntaxNodeExtensionsCSharp.GetDeclarationTypeName(SyntaxFactory.Block()), "Unexpected type Block\r\nParameter name: kind");
 #else
         SyntaxNodeExtensionsCSharp.GetDeclarationTypeName(SyntaxFactory.Block()).Should().Be("type");
 #endif

analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/ControllersHaveMixedResponsibilities.Latest.cs

@@ -871,7 +871,7 @@ public class DoesNotInheritDirectlyFromControllerBase(IS1 s1, IS2 s2) : ApiContr
     public IActionResult A2() { s2.Use(); return Ok(); }
 }
 
-public class InheritsFromController(IS1 s1, IS2 s2) : ControllerBase // Compliant, we report only in classes that inherit directly from ControllerBase
+public class InheritsFromController(IS1 s1, IS2 s2) : Controller // Compliant, we report only in classes that inherit directly from ControllerBase
 {
     public IActionResult A1() { s1.Use(); return Ok(); }
     public IActionResult A2() { s2.Use(); return Ok(); }
@@ -1143,3 +1143,9 @@ public class WithDestructor : ControllerBase // Noncompliant
     public void A1() { s1.Use(); } // Secondary {{May belong to responsibility #1.}}
     public void A2() { s2.Use(); } // Secondary {{May belong to responsibility #2.}}
 }
+
+public class NotAControllerForCoverage
+{
+    private readonly IS1 s1;
+    private readonly IS2 s2;
+}