Small refactoring

SonarSource · Mar 14, 2023 · 72d1ecc · 72d1ecc
1 parent b81eafb
commit 72d1ecc
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/analyzers/src/SonarAnalyzer.Common/Helpers/WildcardPatternMatcher.cs b/analyzers/src/SonarAnalyzer.Common/Helpers/WildcardPatternMatcher.cs
@@ -70,9 +70,9 @@ private static string ToRegex(string wildcardPattern)
             {
                 var ch = wildcardPattern[i];
 
-                if (SpecialChars.IndexOf(ch) != -1)
+                if (SpecialChars.Contains(ch))
                 {
-                    // Escape regexp-specific characters
+                    // Escape regex-specific characters
                     sb.Append('\\').Append(ch);
                 }
                 else if (ch == '*')
@@ -83,7 +83,7 @@ private static string ToRegex(string wildcardPattern)
                         // Zero or more directories
                         if (i + 2 < wildcardPattern.Length && IsSlash(wildcardPattern[i + 2]))
                         {
-                            sb.Append("(?:.*").Append(escapedDirectorySeparator).Append("|)");
+                            sb.Append($"(?:.*{escapedDirectorySeparator}|)");
                             i += 2;
                         }
                         else
@@ -96,13 +96,13 @@ private static string ToRegex(string wildcardPattern)
                     {
                         // Single asterisk
                         // Zero or more characters excluding directory separator
-                        sb.Append("[^").Append(escapedDirectorySeparator).Append("]*?");
+                        sb.Append($"[^{escapedDirectorySeparator}]*?");
                     }
                 }
                 else if (ch == '?')
                 {
                     // Any single character excluding directory separator
-                    sb.Append("[^").Append(escapedDirectorySeparator).Append("]");
+                    sb.Append($"[^{escapedDirectorySeparator}]");
                 }
                 else if (IsSlash(ch))
                 {
@@ -114,13 +114,9 @@ private static string ToRegex(string wildcardPattern)
                     // Single character
                     sb.Append(ch);
                 }
-
                 i++;
             }
-
-            sb.Append('$');
-
-            return sb.ToString();
+            return sb.Append('$').ToString();
         }
 
         private static bool IsSlash(char ch) =>