Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify S5147: Add context specific code examples for Spring Data MongoDB #3912

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Modify S5147: Add context specific code examples for Spring Data MongoDB #3912

wants to merge 1 commit into from

Conversation

pierre-loup-tristant-sonarsource
Copy link
Contributor

@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource commented Apr 23, 2024 •
edited by jira bot

APPSEC-1568

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

daniel-teuchert-sonarsource
daniel-teuchert-sonarsource approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
The string highlighting of the noncompliant example looks a little bit weird but I think there is nothing we can do about it.
Screenshot 2024-04-25 at 15 12 26

@pierre-loup-tristant-sonarsource
Copy link
Contributor Author

Indeed, it highlights the variable name with the color of a literal string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-teuchert-sonarsource daniel-teuchert-sonarsource daniel-teuchert-sonarsource approved these changes

Assignees
No one assigned
Labels
appsec java
Projects
None yet
Milestone
No milestone
2 participants
@pierre-loup-tristant-sonarsource @daniel-teuchert-sonarsource