Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify rule S4830, S5527: Adjustments for Python (APPSEC-1559) #3751

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

egon-okerman-sonarsource
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@egon-okerman-sonarsource egon-okerman-sonarsource changed the title Rule/python/s5527/adjustments appsec 1559 Modify rule S4830, S5527: Adjustments for Python (APPSEC-1559) Mar 8, 2024
Copy link
Contributor

@gaetan-ferry-sonarsource gaetan-ferry-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general except for a small issue in a code example for pyOpenSSL.

rules/S5527/python/highlighting.adoc Outdated Show resolved Hide resolved
rules/S5527/python/how-to-fix-it/openssl.adoc Outdated Show resolved Hide resolved
rules/S5527/python/how-to-fix-it/openssl.adoc Outdated Show resolved Hide resolved
rules/S4830/python/how-to-fix-it/aiohttp.adoc Outdated Show resolved Hide resolved
Co-authored-by: gaetan-ferry-sonarsource <112399173+gaetan-ferry-sonarsource@users.noreply.github.com>
Co-authored-by: gaetan-ferry-sonarsource <112399173+gaetan-ferry-sonarsource@users.noreply.github.com>
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@gaetan-ferry-sonarsource gaetan-ferry-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants