Modify rule S4545: Add VB.NET specifics, Move C# specifics #1571
Conversation
|
SonarQube Quality Gate for 'rspec-tools'
|
|
SonarQube Quality Gate for 'rspec-frontend'
|
antonioaversa
force-pushed
the
Antonio/S4545-debugger-display-attr-existing-members
branch
from
0c34ec6
to
da704cd
Compare
I have restructured a bit the content:
|
rules/S4545/csharp/rule.adoc
Outdated
| The ``DebuggerDisplayAttribute`` is used to determine how an object is displayed in the debugger window. | ||
|
|
||
|
|
||
| The ``DebuggerDisplayAttribute`` constructor takes a single mandatory argument: the string to be displayed in the value column for instances of the type. Any text within curly braces is evaluated as the name of a member, or any complex expression converted to a string value, containing method calls and operators. |
There was a problem hiding this comment.
| The ``DebuggerDisplayAttribute`` constructor takes a single mandatory argument: the string to be displayed in the value column for instances of the type. Any text within curly braces is evaluated as the name of a member, or any complex expression converted to a string value, containing method calls and operators. | |
| The `DebuggerDisplayAttribute` constructor takes a single mandatory argument: the string to be displayed in the value column for instances of the type. Any text within curly braces is evaluated as the name of a field, property, or method or as a complex expression containing method calls and operators that is evaluated to a string. |
There was a problem hiding this comment.
- Double backticks to single backticks => OK
- Member to "field, property or method" => OK ("method" removed, see here)
- "converted to a string value" to "That is evaluated to a string" => The second seems incorrect to me since expressions such as
DebuggerDisplay("{42}")are correctly evaluated, despite42not being evaluated to a string. It's rather that the expression is evaluated to whateverobjectit evaluates to, and then aToString()is called on that object. In any case, I have removed the subordinate altogether.
rules/S4545/vbnet/rule.adoc
Outdated
| The ``DebuggerDisplayAttribute`` is used to determine how an object is displayed in the debugger window. | ||
|
|
||
|
|
||
| The ``DebuggerDisplayAttribute`` constructor takes a single mandatory argument: the string to be displayed in the value column for instances of the type. Any text within curly braces is evaluated as the name of member, or any complex expression converted to a string value, containing method calls and operators. |
There was a problem hiding this comment.
same proposal as above.
There was a problem hiding this comment.
Fixed in the same way it is described in #1571 (comment)
antonioaversa
force-pushed
the
Antonio/S4545-debugger-display-attr-existing-members
branch
from
da704cd
to
1cf3bad
Compare
|
SonarQube Quality Gate for 'rspec-frontend'
|
|
SonarQube Quality Gate for 'rspec-tools'
|
antonioaversa
deleted the
Antonio/S4545-debugger-display-attr-existing-members
branch
Implementation SonarSource/sonar-dotnet#6703
Kept as draft as it is to be merged after SonarSource/sonar-dotnet#6728.
Remark: implementation merged before corresponding RSPEC is ready. Changes to the sonar-dotnet repo are to be expected, when running rspec update upon release.