Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S2166: Add C# and VB.NET #1548

Merged
merged 5 commits into from Feb 6, 2023
Merged

S2166: Add C# and VB.NET #1548

merged 5 commits into from Feb 6, 2023

Conversation

zsolt-kolbay-sonarsource
Copy link
Contributor

antonioaversa
antonioaversa reviewed Feb 6, 2023
View reviewed changes
Copy link
Contributor

@antonioaversa antonioaversa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@andrei-epure-sonarsource : your turn

andrei-epure-sonarsource
andrei-epure-sonarsource approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@andrei-epure-sonarsource andrei-epure-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some minor nitpick suggestions.

rules/S2166/csharp/rule.adoc Outdated Show resolved Hide resolved
rules/S2166/csharp/rule.adoc Outdated Show resolved Hide resolved
@zsolt-kolbay-sonarsource @andrei-epure-sonarsource
Update rules/S2166/csharp/rule.adoc
5f2e097 
Co-authored-by: Andrei Epure <38876598+andrei-epure-sonarsource@users.noreply.github.com>
@zsolt-kolbay-sonarsource @andrei-epure-sonarsource
Update rules/S2166/csharp/rule.adoc
d174f77 
Co-authored-by: Andrei Epure <38876598+andrei-epure-sonarsource@users.noreply.github.com>
@zsolt-kolbay-sonarsource
innerException -> inner
aac70d3
@sonarsource-next
Copy link

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarsource-next
Copy link

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource merged commit f3480df into master Feb 6, 2023
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource deleted the Zsolt/S2166-CSharp-and-VB-description branch February 6, 2023 13:10
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource mentioned this pull request Feb 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonioaversa antonioaversa antonioaversa left review comments

@andrei-epure-sonarsource andrei-epure-sonarsource andrei-epure-sonarsource approved these changes

Assignees
No one assigned
Labels
dotnet
Projects
None yet
Milestone
No milestone
3 participants
@zsolt-kolbay-sonarsource @antonioaversa @andrei-epure-sonarsource